Messages in this thread Patch in this message | | | From | Arnaldo Carvalho de Melo <> | Subject | [PATCH 4/9] perf symbols: Handle NULL dso in dso__name_len | Date | Fri, 30 Mar 2012 13:09:19 -0300 |
| |
From: David Miller <davem@davemloft.net>
We should use "[unknown]" in this case, in concert with the code in _hist_entry__dso_snprintf().
Otherwise we'll crash when recomputing the histogram column lengths in hists__calc_col_len().
Signed-off-by: David S. Miller <davem@davemloft.net> Link: http://lkml.kernel.org/r/20120325.162822.2267799792062571623.davem@davemloft.net Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/symbol.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index d9e995b..c0a028c 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -50,6 +50,8 @@ struct symbol_conf symbol_conf = { int dso__name_len(const struct dso *dso) { + if (!dso) + return strlen("[unknown]"); if (verbose) return dso->long_name_len; -- 1.7.9.2.358.g22243
| |