lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv3 06/16] OMAP: I2C: Fix the mismatch of pm_runtime enable and disable
    Date
    Currently the i2c driver calls the pm_runtime_enable and never
    the disable. This may cause a warning when pm_runtime_enable
    checks for the count match.Attempting to fix the same by calling
    pm_runtime_disable in the error and the remove path.

    Cc: Kevin Hilman <khilman@ti.com>
    Cc: Rajendra Nayak <rnayak@ti.com>
    Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
    ---
    drivers/i2c/busses/i2c-omap.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
    index 1c38572..7df1ea2 100644
    --- a/drivers/i2c/busses/i2c-omap.c
    +++ b/drivers/i2c/busses/i2c-omap.c
    @@ -1124,6 +1124,7 @@ err_unuse_clocks:
    omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
    pm_runtime_put(dev->dev);
    iounmap(dev->base);
    + pm_runtime_disable(&pdev->dev);
    err_free_mem:
    platform_set_drvdata(pdev, NULL);
    kfree(dev);
    @@ -1144,6 +1145,7 @@ omap_i2c_remove(struct platform_device *pdev)
    free_irq(dev->irq, dev);
    i2c_del_adapter(&dev->adapter);
    omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
    + pm_runtime_disable(&pdev->dev);
    iounmap(dev->base);
    kfree(dev);
    mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    --
    1.7.1


    \
     
     \ /
      Last update: 2012-03-30 17:55    [W:0.025 / U:60.864 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site