Messages in this thread | | | Date | Fri, 30 Mar 2012 00:00:40 -0700 | From | Nick Dyer <> | Subject | Re: [PATCH 19/20] Input: atmel_mxt_ts - remove mxt_make_highchg and parse T6 report |
| |
Daniel Kurtz wrote: > On Tue, Mar 20, 2012 at 11:38 PM, Nick Dyer <nick.dyer@itdev.co.uk> wrote: >> mxt_make_highchg exists due to the interrupts being edge triggered. It >> forces the CHG line to go high. >> >> With this implementation, I suspect that if a new message arrives after you >> have read T44 and before you finish processing messages, then the interrupt >> handler will not ever be run. What testing have you done on this? > > Actually, for the MXT224E on which I've been testing, the CHG line > goes high after reading the first byte of the T5 message (in other > words, the first byte of the first message, no matter how many > messages T44 reports).
The CHG line behaviour is configurable - you should find this documented in the data sheet.
> Expect an updated version of this patchset soon. > > Thanks for all of your reviews!
no problem.
-- Nick Dyer Software Engineer, ITDev Ltd Hardware and Software Development Consultancy Website: http://www.itdev.co.uk
| |