lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 75/76] Disable MCP limit exceeded messages from Intel IPS driver
    Date
    From: Andi Kleen <ak@linux.intel.com>

    On a system on the thermal limit these are quite noisy and flood the logs.
    Better would be a counter anyways. But given that we don't even have
    anything for normal throttling this doesn't seem to be urgent either.

    Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Signed-off-by: Len Brown <len.brown@intel.com>
    ---
    drivers/platform/x86/intel_ips.c | 13 ++-----------
    1 file changed, 2 insertions(+), 11 deletions(-)

    diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
    index 88a98cf..f7ba316 100644
    --- a/drivers/platform/x86/intel_ips.c
    +++ b/drivers/platform/x86/intel_ips.c
    @@ -609,25 +609,16 @@ static bool mcp_exceeded(struct ips_driver *ips)
    bool ret = false;
    u32 temp_limit;
    u32 avg_power;
    - const char *msg = "MCP limit exceeded: ";

    spin_lock_irqsave(&ips->turbo_status_lock, flags);

    temp_limit = ips->mcp_temp_limit * 100;
    - if (ips->mcp_avg_temp > temp_limit) {
    - dev_info(&ips->dev->dev,
    - "%sAvg temp %u, limit %u\n", msg, ips->mcp_avg_temp,
    - temp_limit);
    + if (ips->mcp_avg_temp > temp_limit)
    ret = true;
    - }

    avg_power = ips->cpu_avg_power + ips->mch_avg_power;
    - if (avg_power > ips->mcp_power_limit) {
    - dev_info(&ips->dev->dev,
    - "%sAvg power %u, limit %u\n", msg, avg_power,
    - ips->mcp_power_limit);
    + if (avg_power > ips->mcp_power_limit)
    ret = true;
    - }

    spin_unlock_irqrestore(&ips->turbo_status_lock, flags);

    --
    1.7.10.rc2.19.gfae9d


    \
     
     \ /
      Last update: 2012-03-30 12:27    [W:0.021 / U:58.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site