lkml.org 
[lkml]   [2012]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] block, sx8: fix pointer math issue getting fw version
    On Sat, Mar 03, 2012 at 08:00:28AM +0100, Jens Axboe wrote:
    > On 2012-03-03 07:58, Jens Axboe wrote:
    > > On 2012-03-02 20:00, Dan Carpenter wrote:
    > >> "mem" is type u8. We need parenthesis here or it screws up the pointer
    > >> math probably leading to an oops.
    > >
    > > Applied, thanks Dan. I have marked it stable, too.
    >
    > Hmm wait Dan, seems to me that u8 pointer math should be equiv to char *
    > pointer math and hence it'd work just fine. Are you sure this is a bug?

    It's the cast on the line before is what breaks it. We need the
    parentheses so we add first then cast the result.

    regards,
    dan carpenter

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-03-03 09:05    [W:0.022 / U:0.988 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site