lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH resend] ASPM: Fix pcie devices with non-pcie children
    On Thu, Mar 29, 2012 at 2:59 PM, Andrew Morton
    <akpm@linux-foundation.org> wrote:
    > On Thu, 29 Mar 2012 21:56:35 +0100
    > Matthew Garrett <mjg59@srcf.ucam.org> wrote:
    >
    >> On Thu, Mar 29, 2012 at 01:46:14PM -0700, Andrew Morton wrote:
    >>
    >> > Just about the only person who wasn't copied on this email is, umm, the
    >> > PCI maintainer!
    >>
    >> Jesse just handed that off to Bjorn…
    >
    > Oh.  So he did.   My search of MAINTAINERS turned up the probably wrong
    >
    > T:      git git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci.git

    Yep, I'll update MAINTAINERS as soon as I set up a kernel.org tree.

    The patch itself looks fine to me, so in case anybody wants to pick it
    up earlier:

    Acked-by: Bjorn Helgaas <bhelgaas@google.com>

    I do think that ASPM path is disappointingly hard to follow, which
    likely contributed to the bug in the first place.
    pcie_aspm_sanity_check() is a terrible name for something that returns
    0/errno (which is treated as a bool meaning something like "do ASPM on
    this device"). And the idea that we save this blacklist information
    in the form of "link->aspm_enabled = ASPM_STATE_ALL" is weird.

    But obviously, I'm ignorant of ASPM in general.

    Bjorn
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-29 23:51    [W:0.037 / U:30.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site