Messages in this thread | | | Date | Thu, 29 Mar 2012 16:02:33 -0500 | From | Jonathan Nieder <> | Subject | Re: [PATCH resend] ASPM: Fix pcie devices with non-pcie children |
| |
Andrew Morton wrote: > Jonathan Nieder <jrnieder@gmail.com> wrote:
>> From: Matthew Garrett <mjg@redhat.com> >> Date: Tue, 27 Mar 2012 10:17:41 -0400 [...] >> commit 4949be16822e ("PCI: ignore pre-1.1 ASPM quirking >> when ASPM is disabled") changed the behaviour of >> pcie_aspm_sanity_check() to always return 0 if aspm is disabled, in >> order to avoid cases where we changed ASPM state on pre-PCIe 1.1 >> devices. This skipped the secondary function of >> pcie_aspm_sanity_check which was to avoid us enabling ASPM on devices >> that had non-PCIe children, causing trouble later on. [...] >> Could >> you pick it up for linux-next until it makes its way to the PCI tree? [...] > Just about the only person who wasn't copied on this email is, umm, the > PCI maintainer!
Well spotted. Thanks for catching it.
| |