lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/3] IRQ: introduce irq_do_set_affinity() to reduce duplicated code
    On Fri, 30 Mar 2012, Jiang Liu wrote:

    > Introduce irq_do_set_affinity() to reduce duplicated code.
    > This patch also fixes a minor bug in irq_move_masked_irq(),
    > which treats return value IRQ_SET_MASK_OK_NOCOPY as error.

    Again. Please don't do that.

    A bug fix is a bug fix and a cleanup is a cleanup. Mixing both is
    simply wrong. It's also completely non obvious from the subject line
    that this patch contains a bug fix - minor or not is completely
    irrelevant.

    The order is bug fix first, then cleanup and improvements.

    Please be more careful about this.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2012-03-29 20:59    [W:0.024 / U:1.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site