lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/14] edac: Add debufs nodes to allow doing fake error inject
    Date
    Sometimes, it is useful to have a mechanism that generates fake
    errors, in order to test the EDAC core code, and the userspace
    tools.

    Provide such mechanism by adding a few debugfs nodes.

    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    ---
    drivers/edac/edac_mc_sysfs.c | 87 ++++++++++++++++++++++++++++++++++++++++++
    include/linux/edac.h | 7 +++
    2 files changed, 94 insertions(+), 0 deletions(-)

    diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
    index bdd81b4..4ab2e19 100644
    --- a/drivers/edac/edac_mc_sysfs.c
    +++ b/drivers/edac/edac_mc_sysfs.c
    @@ -17,6 +17,7 @@
    #include <linux/edac.h>
    #include <linux/bug.h>
    #include <linux/pm_runtime.h>
    +#include <linux/uaccess.h>

    #include "edac_core.h"
    #include "edac_module.h"
    @@ -786,6 +787,47 @@ static ssize_t mci_max_location_show(struct device *dev,
    return p - data;
    }

    +#ifdef CONFIG_EDAC_DEBUG
    +static ssize_t edac_fake_inject_write(struct file *file,
    + const char __user *data,
    + size_t count, loff_t *ppos)
    +{
    + struct device *dev = file->private_data;
    + struct mem_ctl_info *mci = to_mci(dev);
    + static enum hw_event_mc_err_type type;
    +
    + type = mci->fake_inject_ue ? HW_EVENT_ERR_UNCORRECTED
    + : HW_EVENT_ERR_CORRECTED;
    +
    + printk(KERN_DEBUG
    + "Generating a %s fake error to %d.%d.%d to test core handling. NOTE: this won't test the driver-specific decoding logic.\n",
    + (type == HW_EVENT_ERR_UNCORRECTED) ? "UE" : "CE",
    + mci->fake_inject_layer[0],
    + mci->fake_inject_layer[1],
    + mci->fake_inject_layer[2]
    + );
    + edac_mc_handle_error(type, mci, 0, 0, 0,
    + mci->fake_inject_layer[0],
    + mci->fake_inject_layer[1],
    + mci->fake_inject_layer[2],
    + "FAKE ERROR", "for EDAC testing only", NULL);
    +
    + return count;
    +}
    +
    +static int debugfs_open(struct inode *inode, struct file *file)
    +{
    + file->private_data = inode->i_private;
    + return 0;
    +}
    +
    +static const struct file_operations debug_fake_inject_fops = {
    + .open = debugfs_open,
    + .write = edac_fake_inject_write,
    + .llseek = generic_file_llseek,
    +};
    +#endif
    +
    /* default Control file */
    DEVICE_ATTR(reset_counters, S_IWUSR, NULL, mci_reset_counters_store);

    @@ -836,6 +878,45 @@ static struct device_type mci_attr_type = {
    .release = mci_attr_release,
    };

    +#ifdef CONFIG_EDAC_DEBUG
    +int edac_create_debug_nodes(struct mem_ctl_info *mci)
    +{
    + struct dentry *d, *parent;
    + char name[80];
    + int i;
    +
    + d = debugfs_create_dir(mci->dev.kobj.name, mci->debugfs);
    + if (!d)
    + return -ENOMEM;
    + parent = d;
    +
    + for (i = 0; i < mci->n_layers; i++) {
    + sprintf(name, "fake_inject_%s",
    + edac_layer_name[mci->layers[i].type]);
    + d = debugfs_create_u8(name, S_IRUGO | S_IWUSR, parent,
    + &mci->fake_inject_layer[i]);
    + if (!d)
    + goto nomem;
    + }
    +
    + d = debugfs_create_bool("fake_inject_ue", S_IRUGO | S_IWUSR, parent,
    + &mci->fake_inject_ue);
    + if (!d)
    + goto nomem;
    +
    + d = debugfs_create_file("fake_inject", S_IWUSR, parent,
    + &mci->dev,
    + &debug_fake_inject_fops);
    + if (!d)
    + goto nomem;
    +
    + return 0;
    +nomem:
    + debugfs_remove(mci->debugfs);
    + return -ENOMEM;
    +}
    +#endif
    +
    /*
    * Create a new Memory Controller kobject instance,
    * mc<id> under the 'mc' directory
    @@ -901,6 +982,9 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci)
    goto fail;
    #endif

    +#ifdef CONFIG_EDAC_DEBUG
    + edac_create_debug_nodes(mci);
    +#endif
    return 0;

    fail:
    @@ -925,6 +1009,9 @@ void edac_remove_sysfs_mci_device(struct mem_ctl_info *mci)

    debugf0("%s()\n", __func__);

    +#ifdef CONFIG_EDAC_DEBUG
    + debugfs_remove(mci->debugfs);
    +#endif
    #ifdef CONFIG_EDAC_LEGACY_SYSFS
    edac_delete_csrow_objects(mci);
    #endif
    diff --git a/include/linux/edac.h b/include/linux/edac.h
    index 81ca2ba..3bfdcb9 100644
    --- a/include/linux/edac.h
    +++ b/include/linux/edac.h
    @@ -14,6 +14,7 @@

    #include <linux/atomic.h>
    #include <linux/device.h>
    +#include <linux/debugfs.h>

    #define EDAC_OPSTATE_INVAL -1
    #define EDAC_OPSTATE_POLL 0
    @@ -608,6 +609,12 @@ struct mem_ctl_info {

    /* the internal state of this controller instance */
    int op_state;
    +
    +#ifdef CONFIG_EDAC_DEBUG
    + struct dentry *debugfs;
    + u8 fake_inject_layer[EDAC_MAX_LAYERS];
    + u32 fake_inject_ue;
    +#endif
    };

    #endif
    --
    1.7.8


    \
     
     \ /
      Last update: 2012-03-29 19:11    [W:0.026 / U:0.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site