lkml.org 
[lkml]   [2012]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/13] Add a kerneldoc comment to spin_is_locked() that discourages its usage

> +/**
> + * spin_is_locked() - Check if a spinlock is being held.
> + * @lock: Lock to check.
> + *
> + * This function should normally not be used. Especially using it in
> + * WARN and BUG_ONs is usually incorrect or redundant.
> + * If you want to check if a lock is held in a function
> + * use lockdep_assert_held(). A lot of other usages are racy.
> + */

Maybe add a reference to the section you previously added to spinlock.txt?

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-03-28 10:53    [W:0.116 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site