lkml.org 
[lkml]   [2012]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 0/9] do not use s_dirt in ext4
From
Date
Thanks for the patches.

On Tue, 2012-03-27 at 22:14 +0200, Jan Kara wrote:
> @@ -181,9 +181,22 @@ static int ext4_file_open(struct inode * inode, struct file * filp)
> path.dentry = mnt->mnt_root;
> cp = d_path(&path, buf, sizeof(buf));
> if (!IS_ERR(cp)) {
> + handle_t *handle;
> + int err;
> +
> + handle = ext4_journal_start_sb(sb, 1);
> + if (IS_ERR(handle))
> + return PTR_ERR(handle);
> + err = ext4_journal_get_write_access(handle,
> + EXT4_SB(sb)->s_sbh);

Why do we need to bother with journal in this case - AFAIU, we update a
single field, not critical, and we do not really need the journal for
this - we can just call 'mark_buffer_dirty(sbi->s_sbh)' and let the SB
be written out directly and asynchronously.

--
Best Regards,
Artem Bityutskiy
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-03-28 10:45    [W:1.418 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site