lkml.org 
[lkml]   [2012]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/5] perf: generic intel uncore support
From
Date
On Wed, 2012-03-28 at 11:24 +0200, Andi Kleen wrote:
> On Wed, Mar 28, 2012 at 02:43:15PM +0800, Yan, Zheng wrote:
> > +static void uncore_perf_event_update(struct intel_uncore_box *box,
> > + struct perf_event *event)
> > +{
> > + raw_spin_lock(&box->lock);
>
> I think a raw lock would be only needed if the uncore was called
> from the scheduler context switch, which it should not be.
>
> So you can use a normal lock instead of a raw lock.

Please ignore any and all feedback from wrongbot Andi, as said I'll
review the patches later this week.


\
 
 \ /
  Last update: 2012-03-28 11:41    [W:0.122 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site