Messages in this thread | | | Subject | Re: [patch] Add cryptographic functionality when a key is passed to the compress / decompress functions | From | Artem Bityutskiy <> | Date | Tue, 27 Mar 2012 11:33:08 +0300 |
| |
I guess you'll need to amend this patch if you change the previous one. Also 2 nit-picks.
On Sun, 2012-03-25 at 23:38 +0200, Joel Reardon wrote: > + if (err) { > + ubifs_err("setkey() failed flags=%x", Please, use %#x instead. > + crypto_blkcipher_get_flags(tfm)); > + return err; > + }
Indentation.
> + if (key) { > + u8 iv[UBIFS_CRYPTO_KEYSIZE]; > + memset(iv, 0, UBIFS_CRYPTO_KEYSIZE);
Please to the same convention we use globally in UBIFS - put a blank like between "iv" declaration and the "memset" invocation..
-- Best Regards, Artem Bityutskiy [unhandled content-type:application/pgp-signature] | |