lkml.org 
[lkml]   [2012]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] Add cryptographic functionality when a key is passed to the compress / decompress functions
From
Date
I guess you'll need to amend this patch if you change the previous one.
Also 2 nit-picks.

On Sun, 2012-03-25 at 23:38 +0200, Joel Reardon wrote:
> + if (err) {
> + ubifs_err("setkey() failed flags=%x",
Please, use %#x instead.
> + crypto_blkcipher_get_flags(tfm));
> + return err;
> + }

Indentation.


> + if (key) {
> + u8 iv[UBIFS_CRYPTO_KEYSIZE];
> + memset(iv, 0, UBIFS_CRYPTO_KEYSIZE);

Please to the same convention we use globally in UBIFS - put a blank
like between "iv" declaration and the "memset" invocation..

--
Best Regards,
Artem Bityutskiy
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-03-27 10:33    [W:1.648 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site