Messages in this thread | | | Subject | Re: [PATCH v5]: Hibernation: lower/better control the amount of pages used for buffering | From | Bojan Smojver <> | Date | Wed, 28 Mar 2012 09:39:59 +1100 |
| |
On Wed, 2012-03-28 at 00:41 +0200, Rafael J. Wysocki wrote: > If you define a macro, please use capital letters in the name. Also, > the parentheses aren't necessary I think. > > Perhaps it would be better to use a static inline function instead?
Hmm, was just following the nr_free_pages() definition in swap.h:
/* Definition of global_page_state not available yet */ #define nr_free_pages() global_page_state(NR_FREE_PAGES)
Still no good?
-- Bojan
| |