lkml.org 
[lkml]   [2012]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] firmware_class: Reorganize fw_create_instance()
Date
On Tuesday, March 27, 2012, Greg KH wrote:
> On Tue, Mar 27, 2012 at 11:47:06PM +0200, Rafael J. Wysocki wrote:
> > On Tuesday, March 27, 2012, Stephen Boyd wrote:
> > > Recent patches to split up the three phases of request_firmware()
> > > lead to a casting away of const in fw_create_instance(). We can
> > > avoid this cast by splitting up fw_create_instance() a bit.
> > >
> > > Make _request_firmware_setup() return a struct fw_priv and use
> > > that struct instead of passing struct firmware to
> > > _request_firmware(). Move the uevent and device file creation
> > > bits to the loading phase and rename the function to
> > > _request_firmware_load() to better reflect its purpose.
> > >
> > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> >
> > Looks good to me.
> >
> > Greg, if that's fine with you, I'll add this patch (and the next one)
> > to my firmware_class series you've looked at recently.
>
> Yes, it's fine with me:
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Cool, thanks!

Rafael


\
 
 \ /
  Last update: 2012-03-27 23:53    [W:0.063 / U:4.348 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site