[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC PATCHSET] perf ui: Small preparation on further UI work
    On Mon, Mar 26, 2012 at 11:51 AM, Namhyung Kim <> wrote:
    > This is my initial work of UI generalization. As we now get GTK2 support on
    > perf report, improve setup_browser() to handle it properly so that we can
    > add various UI specific initialization codes to the function. At least, we
    > need basic error/warning handlers ASAP to see what's going on when an error
    > occurred, IMHO.
    > I put new file setup.c under ui directory (not under util/ui) and it may or
    > may not be compiled depending on the system configuration. I think it'd be
    > better moving generic UI codes to the directory and TUI specific codes to
    > ui/tui, and so on, so that the util directory doesn't contain any UI codes.
    > But before proceeding, I'd like to listen to your opinions :).

    The series looks good to me:

    Acked-by: Pekka Enberg <>


     \ /
      Last update: 2012-03-26 11:49    [W:0.019 / U:93.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site