lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 20/20 v3] sparc/mm/fault_64.c: Port OOM changes to do_sparc64_fault
    From
    From: Kautuk Consul <consul.kautuk@gmail.com>
    Date: Mon, 26 Mar 2012 11:33:17 -0400

    > + fault = handle_mm_fault(mm, vma, address,
    > + flags | ((fault_code & FAULT_CODE_WRITE) ?
    > + FAULT_FLAG_WRITE : 0);

    This is so shockingly gross I'm at a loss for words. Why are you
    tabbing this crap all the way into outer-space?

    Make the "flags | ..." line up with the first column after the
    openning parenthesis of "handle_mm_fault(".

    > + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
    > + 1, regs, address);

    Same problem.

    > + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN,
    > + 1, regs, address);

    Same problem.

    You're making the coding style worse each iteration, not better.


    \
     
     \ /
      Last update: 2012-03-26 22:13    [W:0.019 / U:35.488 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site