lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRE: [PATCH 2/2] regulator: Remove _en_reg, _en_bit and _ops parameters from tps65090_REG macro
    > Both _en_bit and _ops parameters for all DCDCs and FETs are the same, so we
    > can hardcode it in tps65090_REG macro.
    >
    > _en_reg can be calculated by _id + 12, so we can also remove it.
    Looks good to me.
    Acked by: Venu Byravarasu <vbyravarasu@nvidia.com>

    > Signed-off-by: Axel Lin <axel.lin@gmail.com>
    > ---
    > drivers/regulator/tps65090-regulator.c | 28 ++++++++++++++--------------
    > 1 files changed, 14 insertions(+), 14 deletions(-)
    >
    > diff --git a/drivers/regulator/tps65090-regulator.c
    > b/drivers/regulator/tps65090-regulator.c
    > index 470ca7e..7baff2e 100644
    > --- a/drivers/regulator/tps65090-regulator.c
    > +++ b/drivers/regulator/tps65090-regulator.c
    > @@ -94,31 +94,31 @@ static struct regulator_ops tps65090_ops = {
    > .is_enabled = tps65090_reg_is_enabled,
    > };
    >
    > -#define tps65090_REG(_id, _en_reg, _en_bit, _ops) \
    > +#define tps65090_REG(_id) \
    > { \
    > - .reg_en_reg = _en_reg, \
    > - .en_bit = _en_bit, \
    > + .reg_en_reg = (TPS65090_ID_##_id) + 12, \
    > + .en_bit = 0, \
    > .id = TPS65090_ID_##_id, \
    > .desc = { \
    > .name = tps65090_rails(_id), \
    > .id = TPS65090_ID_##_id, \
    > - .ops = &_ops, \
    > + .ops = &tps65090_ops, \
    > .type = REGULATOR_VOLTAGE, \
    > .owner = THIS_MODULE, \
    > }, \
    > }
    >
    > static struct tps65090_regulator TPS65090_regulator[] = {
    > - tps65090_REG(DCDC1, 12, 0, tps65090_ops),
    > - tps65090_REG(DCDC2, 13, 0, tps65090_ops),
    > - tps65090_REG(DCDC3, 14, 0, tps65090_ops),
    > - tps65090_REG(FET1, 15, 0, tps65090_ops),
    > - tps65090_REG(FET2, 16, 0, tps65090_ops),
    > - tps65090_REG(FET3, 17, 0, tps65090_ops),
    > - tps65090_REG(FET4, 18, 0, tps65090_ops),
    > - tps65090_REG(FET5, 19, 0, tps65090_ops),
    > - tps65090_REG(FET6, 20, 0, tps65090_ops),
    > - tps65090_REG(FET7, 21, 0, tps65090_ops),
    > + tps65090_REG(DCDC1),
    > + tps65090_REG(DCDC2),
    > + tps65090_REG(DCDC3),
    > + tps65090_REG(FET1),
    > + tps65090_REG(FET2),
    > + tps65090_REG(FET3),
    > + tps65090_REG(FET4),
    > + tps65090_REG(FET5),
    > + tps65090_REG(FET6),
    > + tps65090_REG(FET7),
    > };
    >
    > static inline struct tps65090_regulator *find_regulator_info(int id)
    > --
    > 1.7.5.4
    >
    >

    \
     
     \ /
      Last update: 2012-03-26 08:53    [W:0.023 / U:123.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site