lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]drivers:staging:octeon Fix typos in staging:octeon
On 03/26/2012 07:26 AM, Justin P. Mattock wrote:
> From: "Justin P. Mattock"<justinmattock@gmail.com>
>
> The below patch fixes some typos an comments I found while reading.
>
> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>
> ---
> drivers/staging/octeon/ethernet-rx.c | 2 +-
> drivers/staging/octeon/ethernet-tx.c | 10 +++++-----
> drivers/staging/octeon/ethernet-util.h | 2 +-
> drivers/staging/octeon/ethernet.c | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)

For the most part I am fine with this, however ...

[...]
> --- a/drivers/staging/octeon/ethernet-tx.c
> +++ b/drivers/staging/octeon/ethernet-tx.c
> @@ -61,7 +61,7 @@
> * You can define GET_SKBUFF_QOS() to override how the skbuff output
> * function determines which output queue is used. The default
> * implementation always uses the base queue for the port. If, for
> - * example, you wanted to use the skb->priority fieid, define
> + * example, you wanted to use the skb->priority field, define
> * GET_SKBUFF_QOS as: #define GET_SKBUFF_QOS(skb) ((skb)->priority)
> */
> #ifndef GET_SKBUFF_QOS
> @@ -164,8 +164,8 @@ int cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
> #endif
>
> /*
> - * Prefetch the private data structure. It is larger that one
> - * cache line.
> + * Prefetch the private data structure. If it is larger than the
> + * one cache line.
> */

The size of the private data structure is known, and it is indeed larger
than a single cache line. So if you are intent on fixing comments, lets
not make this conditional and go ahead and remove that 'If'.

Thanks,
David Daney


\
 
 \ /
  Last update: 2012-03-26 19:29    [W:0.071 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site