lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH v1] regulator: i.MX35-PDK Add regulator support

    Hi Mark,

    Thanks for you quick responds and comments.

    On Mon, Mar 26, 2012 at 04:36:33PM +0200, Alex Gershgorin wrote:

    > +static struct regulator_init_data sw1_init = {
    > + .constraints = {
    > + .name = "SW1",
    > + .min_uV = 600000,
    > + .max_uV = 1375000,
    > + .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE,
    > + .valid_modes_mask = 0,
    > + .always_on = 1,
    > + .boot_on = 1,
    > + }
    > +};

    > >These constraints don't make sense, you've got a voltage range and the
    > >ability to change voltages but no consumers so nothing that could ever
    > >change the voltage...

    Yes, you are right I will add consumers.

    > +static struct regulator_init_data vpll_init = {
    > + .constraints = {
    > + .name = "VPLL",
    > + .min_uV = 1050000,
    > + .max_uV = 1800000,
    > + .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE,
    > + .boot_on = 1,
    > + }
    > +};

    > >...and in many cases the supply names don't look like things I'd expect
    > >to be varying too much at runtime. It looks like you just typed the
    > >maximum datasheet ranges in, not things that make sense for the board.

    It's not quite true, I was based on the Freescale BSP and I assume, that this is checked.
    I also tested it on v3.3

    Regards,
    Alex Gershgorin



    \
     
     \ /
      Last update: 2012-03-26 17:31    [W:0.030 / U:0.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site