lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/7] pch_uart: change type to u8
    Date
    Target uart register access size is 8bit.
    However, 32bit is used at 2 points.

    This patch modifies type "unsigned int" to "unsigned char".

    Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
    ---
    drivers/tty/serial/pch_uart.c | 12 ++++--------
    1 files changed, 4 insertions(+), 8 deletions(-)

    diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
    index 80609e4..6347f01 100644
    --- a/drivers/tty/serial/pch_uart.c
    +++ b/drivers/tty/serial/pch_uart.c
    @@ -556,14 +556,10 @@ static int pch_uart_hal_read(struct eg20t_port *priv, unsigned char *buf,
    return i;
    }

    -static unsigned int pch_uart_hal_get_iid(struct eg20t_port *priv)
    +static unsigned char pch_uart_hal_get_iid(struct eg20t_port *priv)
    {
    - unsigned int iir;
    - int ret;
    -
    - iir = ioread8(priv->membase + UART_IIR);
    - ret = (iir & (PCH_UART_IIR_IID | PCH_UART_IIR_TOI | PCH_UART_IIR_IP));
    - return ret;
    + return ioread8(priv->membase + UART_IIR) &\
    + (PCH_UART_IIR_IID | PCH_UART_IIR_TOI | PCH_UART_IIR_IP);
    }

    static u8 pch_uart_hal_get_line_status(struct eg20t_port *priv)
    @@ -1049,7 +1045,7 @@ static irqreturn_t pch_uart_interrupt(int irq, void *dev_id)
    unsigned int handled;
    u8 lsr;
    int ret = 0;
    - unsigned int iid;
    + unsigned char iid;
    unsigned long flags;

    spin_lock_irqsave(&priv->port.lock, flags);
    --
    1.7.7.6


    \
     
     \ /
      Last update: 2012-03-26 07:47    [W:0.022 / U:61.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site