Messages in this thread | | | Date | Mon, 26 Mar 2012 13:24:02 +0200 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH RFC dontapply] kvm_para: add mmio word store hypercall |
| |
On Mon, Mar 26, 2012 at 12:29:21PM +0200, Gleb Natapov wrote: > > > > + gpa = hc_gpa(vcpu, a1, a2); > > > > + if (!write_mmio(vcpu, gpa, 2, &a0) && run) { > > > > > > What's this && run thing? > > > > I'm not sure - copied this from another other place in emulation: > > arch/x86/kvm/x86.c:4953: if (!write_mmio(vcpu, gpa, 2, &a0) && run) > > > What git tree is this from? I think that's the one you added.
Ugh. My mistake. So the answer is this, as I said, this is on an ancient tree that did not have 112592da0dc2460c95e8a89d0c5657c6a30286aa I'll remove this check, thanks for pointing this out.
| |