lkml.org 
[lkml]   [2012]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 05/11] m68k/atari: Add missing platform check before registering platform devices
    From
    Hi Geert,


    >> How about this instead - probe for the EtherNAT config register, and
    >> register devices only if found?
    >
    > That's even better, but logically, it's an extra change on top, so I'd like
    > to keep it separate.

    OK, I'll resend as soon as I've pulled your latest changes.

    >> +    if (MACH_IS_ATARI) {
    >
    > I prefer the "if (!MACH_IS_ATARI) return -ENODEV;" at the top, as it
    >  - means less code to change if more platform devices are added,
    >  - means less source code to keep on your mental stack when reading the code,
    >  - decreases indentation for the rest of the function.

    OK; do you want the tests and platform calls conditional on config
    options (we only need to have the platform data available if there's a
    driver or module built to use it)?

    Cheers,

    Michael
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-25 20:57    [W:0.019 / U:0.420 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site