Messages in this thread | | | Subject | Re: [PATCH 2/2] enable dumpstack() to printk log level | From | "he, bo" <> | Date | Mon, 26 Mar 2012 08:59:29 +0800 |
| |
On Fri, 2012-03-23 at 13:22 +0100, Ingo Molnar wrote: > * he, bo <bo.he@intel.com> wrote: > > > --- a/arch/x86/kernel/dumpstack.c > > +++ b/arch/x86/kernel/dumpstack.c > > @@ -177,20 +177,29 @@ void show_stack(struct task_struct *task, unsigned long *sp) > > } Ingo,
Thanks for your kind comments. It's the 1st time for me to send patches to LKML. There are 2 patches. I sent the 1st one to a wrong address. I will resend the 2 patches.
> > > > /* > > - * The architecture-independent dump_stack generator > > + * The architecture-independent dump_stack_log_lvl generator > > I guess it wants to say "architecture-dependent"? Right. I will change it to architecture-dependent.
> > > + show_trace_log_lvl(NULL, NULL, &stack, bp, log_lvl); > > +} > > +EXPORT_SYMBOL(dump_stack_log_lvl); > > this should be a _GPL export. Yes. I will change it.
> > > +} > > +EXPORT_SYMBOL(dump_stack_log_lvl); Yes. I will change it.
| |