[lkml]   [2012]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 21/25] gfs2: use i_op->atomic_create()
    On Wed, Mar 07, 2012 at 10:22:38PM +0100, Miklos Szeredi wrote:
    > From: Miklos Szeredi <>
    > GFS2 doesn't open the file in ->create, but it does check the LOOKUP_EXCL flag
    > in it's create function. Convert to using ->atomic_create and checking O_EXCL
    > so that the nameidata argument is no longer necessary.

    It seems odd that we require implementing ->atomic_create even if we
    don't actually do an atomic create but just want to look at the flags.

    In fact I wonder if we really need to bother with having ->atomic_create
    and ->create, or if we should have one method (kinda contra my previous
    stance that ->atomic_open and ->atomic_create should be one).

    This method then could or could not return a file pointer, but it would
    always be the entry point for creates.

     \ /
      Last update: 2012-03-24 15:31    [W:0.018 / U:3.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site