Messages in this thread |  | | | From | Ulrich Drepper <> | | Date | Sat, 24 Mar 2012 08:26:19 -0400 | | Subject | last fs/proc/array.c change |
| |
Not sure whether this has already been reported, at least I haven't seen it. A recent patch to fs/proc/array.c contained this:
- seq_printf(m, "%lu %lu %lu %lu 0 %lu 0\n", - size, resident, shared, text, data); + /* + * For quick read, open code by putting numbers directly + * expected format is + * seq_printf(m, "%lu %lu %lu %lu 0 %lu 0\n", + * size, resident, shared, text, data); + */ + seq_put_decimal_ull(m, 0, size); + seq_put_decimal_ull(m, ' ', resident); + seq_put_decimal_ull(m, ' ', shared); + seq_put_decimal_ull(m, ' ', text); + seq_put_decimal_ull(m, ' ', 0); + seq_put_decimal_ull(m, ' ', text); + seq_put_decimal_ull(m, ' ', 0); + seq_putc(m, '\n');
See the second to last seq_put_decimal_ull. This is a copy&paste mistake since given the original format it should read
+ seq_put_decimal_ull(m, ' ', data);
(i.e., data instead of text).
|  |