lkml.org 
[lkml]   [2012]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
Subjectlast fs/proc/array.c change
Not sure whether this has already been reported, at least I haven't
seen it. A recent patch to fs/proc/array.c contained this:


- seq_printf(m, "%lu %lu %lu %lu 0 %lu 0\n",
- size, resident, shared, text, data);
+ /*
+ * For quick read, open code by putting numbers directly
+ * expected format is
+ * seq_printf(m, "%lu %lu %lu %lu 0 %lu 0\n",
+ * size, resident, shared, text, data);
+ */
+ seq_put_decimal_ull(m, 0, size);
+ seq_put_decimal_ull(m, ' ', resident);
+ seq_put_decimal_ull(m, ' ', shared);
+ seq_put_decimal_ull(m, ' ', text);
+ seq_put_decimal_ull(m, ' ', 0);
+ seq_put_decimal_ull(m, ' ', text);
+ seq_put_decimal_ull(m, ' ', 0);
+ seq_putc(m, '\n');

See the second to last seq_put_decimal_ull. This is a copy&paste
mistake since given the original format it should read

+ seq_put_decimal_ull(m, ' ', data);

(i.e., data instead of text).


\
 
 \ /
  Last update: 2012-03-24 13:29    [from the cache]
©2003-2011 Jasper Spaans