lkml.org 
[lkml]   [2012]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: Merge x86_32 and x86_64 cpu_idle()

    * Richard Weinberger <richard@nod.at> wrote:

    > Both functions are mostly identical, so we can merge them.

    Okay, so while looking at the patch I got a bit worried about
    the 'mostly' qualifier ;-)

    You could ease that worry by adding an explanation to the
    changelog that itemizes the differences, explains which
    architecture is affected by the changes in what way and gives us
    the warm fuzzy feeling that everything has been considered and
    no ill can come out of using a 'mostly' identical idling
    function in the future.

    ( You should also pick up Frederic's ack for the next
    submission of this patch. )

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2012-03-24 08:29    [W:0.019 / U:60.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site