lkml.org 
[lkml]   [2012]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectOn patch "device.h: audit and cleanup users in main include dir"
Hi Paul,

commit 313162d0b83836e2f57e51b9b8650fb4b9c396ea is not 100.00% correct.

--- a/include/linux/firewire.h
+++ b/include/linux/firewire.h
@@ -2,7 +2,6 @@
#define _LINUX_FIREWIRE_H

#include <linux/completion.h>
-#include <linux/device.h>
#include <linux/dma-mapping.h>
#include <linux/kernel.h>
#include <linux/kref.h>
@@ -68,6 +67,8 @@
#define CSR_MODEL 0x17
#define CSR_DIRECTORY_ID 0x20

+struct device;
+
struct fw_csr_iterator {
const u32 *p;
const u32 *end;
But struct fw_device and struct fw_unit, defined in include/firewire.h,
incorporate struct device.

Furthermore, the inline function definitions
fw_device,
fw_unit,
fw_unit_get,
fw_unit_put,
fw_parent_device
all require definitions from linux/device.h.
--
Stefan Richter
-=====-===-- --== ==---
http://arcgraph.de/sr/

\
 
 \ /
  Last update: 2012-03-24 21:23    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site