Messages in this thread | | | Date | Thu, 22 Mar 2012 11:02:06 +0100 | From | Jan Kara <> | Subject | Re: [PATCH v1 3/9] ext4: remove useless s_dirt assignment |
| |
On Tue 20-03-12 16:41:23, Artem Bityutskiy wrote: > From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > Clean-up ext4 a tiny bit by removing useless s_dirt assignment in > 'ext4_fill_super()' because a bit later we anyway call 'ext4_setup_super()' > which writes the superblock to the media unconditionally. > > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Looks good. Reviewed-by: Jan Kara <jack@suse.cz>
Honza > --- > fs/ext4/super.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index c1f5111..d280bb6 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -3415,7 +3415,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) > #else > es->s_flags |= cpu_to_le32(EXT2_FLAGS_SIGNED_HASH); > #endif > - sb->s_dirt = 1; > } > > /* Handle clustersize */ > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |