Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 22 Mar 2012 13:52:14 -0700 | Subject | Re: Regression introduced by bfcfaa77bdf0f775263e906015982a608df01c76 (vfs: use 'unsigned long' accesses for dcache name comparison and hashing) |
| |
On Thu, Mar 22, 2012 at 1:44 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > > See upthread for diff doing just that ;-) Let's see if that fixes the > crap guys are seeing... BTW, you have used full_name_hash(), just not > on something 8 char long - devpts uses d_alloc_name(), but pty numbers > tend to be less than ten millions...
Moving the "*=9" down to the "next" iteration does fix it for me in my user-space test I just whipped up. Not exhaustive, but at least the test confirms the thinking.
But yeah, let's verify that it also fixes the actual problem being reported.
And you're right, I don't have ten million pty's ;)
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |