lkml.org 
[lkml]   [2012]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] genirq: Get rid of unneeded force parameter in irq_finalize_oneshot()
On Thu, Mar 22, 2012 at 11:32:26AM +0100, Thomas Gleixner wrote:
> Wrong.
>
> CPU 0 CPU 1
>
> do_exit()
> check(PF_EXITING)
> set_bit(IRQTF_RUNTHREAD)
> ...
> set(PF_EXITING)
> exit_irq_thread()

Thomas,

Did not you pick this code with 7140ea1 commit?

@@ -845,6 +842,13 @@ void exit_irq_thread(void)

desc = irq_to_desc(action->irq);

+ /*
+ * If IRQTF_RUNTHREAD is set, we need to decrement
+ * desc->threads_active and wake possible waiters.
+ */
+ if (test_and_clear_bit(IRQTF_RUNTHREAD, &action->thread_flags))
+ wake_threads_waitq(desc);
+
/* Prevent a stale desc->threads_oneshot */
irq_finalize_oneshot(desc, action, true);
}

>
> if (test_bit(IRQTF_RUNTHREAD))
> goto out;
>
> -> FAIL
>
> Thanks,
>
> tglx

--
Regards,
Alexander Gordeev
agordeev@redhat.com


\
 
 \ /
  Last update: 2012-03-22 12:09    [W:0.084 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site