Messages in this thread | | | From | "Turquette, Mike" <> | Date | Wed, 21 Mar 2012 13:32:49 -0700 | Subject | Re: [PATCH 1/4] clk: fixed-rate: Don't open code kstrdup() |
| |
On Wed, Mar 21, 2012 at 1:01 PM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > Save a little code by using the library function. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Hi Mark,
Thanks for the patch. I've already solved this in my clk-fixes branch (working on it now, not yet on the list). I'm going to re-use the same approach for the fixed-rate clock as is used for the divider and gate; the registration functions for those types store the parent_name in the struct clk_foo and use kstrdup as your patch does below.
Thanks again, Mike
> --- > drivers/clk/clk-fixed-rate.c | 7 +------ > 1 files changed, 1 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c > index 90c79fb..cf84e41 100644 > --- a/drivers/clk/clk-fixed-rate.c > +++ b/drivers/clk/clk-fixed-rate.c > @@ -45,7 +45,6 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name, > { > struct clk_fixed_rate *fixed; > char **parent_names = NULL; > - u8 len; > > fixed = kzalloc(sizeof(struct clk_fixed_rate), GFP_KERNEL); > > @@ -63,14 +62,10 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name, > if (! parent_names) > goto out; > > - len = sizeof(char) * strlen(parent_name); > - > - parent_names[0] = kmalloc(len, GFP_KERNEL); > + parent_names[0] = kstrdup(parent_name, GFP_KERNEL); > > if (!parent_names[0]) > goto out; > - > - strncpy(parent_names[0], parent_name, len); > } > > out: > -- > 1.7.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |