Messages in this thread | | | Date | Tue, 20 Mar 2012 23:05:44 -0700 | From | Josh Triplett <> | Subject | Re: [PATCH] checkpatch: Check for quoted strings broken across lines |
| |
On Tue, Mar 20, 2012 at 09:35:58PM -0700, Joe Perches wrote: > On Tue, 2012-03-20 at 21:28 -0700, Josh Triplett wrote: > > The heuristics in the patch I submitted almost completely eliminate > > false positives, which makes my patch suitable for use without --strict. > > Yup, this patch is better than the one I submitted.
OK. Andrew, could you substitute my patch for Joe's in your tree?
> One improvement might be to check for a line continuation \ > on $prevline and still produce a warning in that case.
I'd suggest doing that one as a separate check, "unnecessary line continuation", which should flag any use of a line continuation other than with a preprocessor directive. I don't think combining that with the wrapped-string check makes sense.
- Josh Triplett
| |