lkml.org 
[lkml]   [2012]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/8] ext2: cleanup ext2_sync_super a bit
    Date
    From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

    We have many 'EXT2_SB()' in 'ext2_sync_super()' and I am going to introduce a
    new one. The code will be a bit nicer if I introduce an 'sbi' pointer instead.
    So this patch is just a tiny preparational cleanup.

    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
    ---
    fs/ext2/super.c | 10 ++++++----
    1 files changed, 6 insertions(+), 4 deletions(-)

    diff --git a/fs/ext2/super.c b/fs/ext2/super.c
    index 95dc25f..4eee017 100644
    --- a/fs/ext2/super.c
    +++ b/fs/ext2/super.c
    @@ -1160,6 +1160,8 @@ static void ext2_clear_super_error(struct super_block *sb)
    static void ext2_sync_super(struct super_block *sb, struct ext2_super_block *es,
    int wait)
    {
    + struct ext2_sb_info *sbi = EXT2_SB(sb);
    +
    sb->s_dirt = 0;
    /*
    * Make sure we first mark the superblock as clean and then start
    @@ -1168,15 +1170,15 @@ static void ext2_sync_super(struct super_block *sb, struct ext2_super_block *es,
    smp_wmb();

    ext2_clear_super_error(sb);
    - spin_lock(&EXT2_SB(sb)->s_lock);
    + spin_lock(&sbi->s_lock);
    es->s_free_blocks_count = cpu_to_le32(ext2_count_free_blocks(sb));
    es->s_free_inodes_count = cpu_to_le32(ext2_count_free_inodes(sb));
    es->s_wtime = cpu_to_le32(get_seconds());
    /* unlock before we do IO */
    - spin_unlock(&EXT2_SB(sb)->s_lock);
    - mark_buffer_dirty(EXT2_SB(sb)->s_sbh);
    + spin_unlock(&sbi->s_lock);
    + mark_buffer_dirty(sbi->s_sbh);
    if (wait)
    - sync_dirty_buffer(EXT2_SB(sb)->s_sbh);
    + sync_dirty_buffer(sbi->s_sbh);
    }

    /*
    --
    1.7.7.6


    \
     
     \ /
      Last update: 2012-03-21 17:19    [W:0.021 / U:29.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site