Messages in this thread | | | Date | Wed, 21 Mar 2012 09:09:10 -0700 | From | Tejun Heo <> | Subject | Re: Patch workqueue: create new slab cache instead of hacking |
| |
On Wed, Mar 21, 2012 at 09:12:04AM -0500, Christoph Lameter wrote: > How about this instead? > > Subject: workqueues: Use new kmem cache to get aligned memory for workqueues > > The workqueue logic currently improvises by doing a kmalloc allocation and > then aligning the object. Create a slab cache for that purpose with the > proper alignment instead. > > Cleans up the code and makes things much simpler. No need anymore to carry > an additional pointer to the beginning of the kmalloc object. > > Signed-off-by: Christoph Lameter <cl@linux.com>
I don't know. At this point, this is only for singlethread and unbound workqueues and we don't have too many of them left at this point. I'd like to avoid creating a slab cache for this. How about just leaving it be? If we develop other use cases for larger alignments, let's worry about implementing something common then.
Thanks.
-- tejun
| |