lkml.org 
[lkml]   [2012]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Patch workqueue: create new slab cache instead of hacking
On Wed, Mar 21, 2012 at 09:12:04AM -0500, Christoph Lameter wrote:
> How about this instead?
>
> Subject: workqueues: Use new kmem cache to get aligned memory for workqueues
>
> The workqueue logic currently improvises by doing a kmalloc allocation and
> then aligning the object. Create a slab cache for that purpose with the
> proper alignment instead.
>
> Cleans up the code and makes things much simpler. No need anymore to carry
> an additional pointer to the beginning of the kmalloc object.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>

I don't know. At this point, this is only for singlethread and
unbound workqueues and we don't have too many of them left at this
point. I'd like to avoid creating a slab cache for this. How about
just leaving it be? If we develop other use cases for larger
alignments, let's worry about implementing something common then.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-03-21 17:11    [W:0.270 / U:0.232 seconds]
©2003-2014 Jasper Spaans. Advertise on this site