lkml.org 
[lkml]   [2012]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] x86: export 'pcibios_enabled' as GPL
    On Wed, 21 Mar 2012 12:37:21 +0800
    Wang YanQing <udknight@gmail.com> wrote:

    > On Sun, Mar 18, 2012 at 06:03:41PM -0700, Randy Dunlap wrote:
    > > From: Randy Dunlap <rdunlap@xenotime.net>
    > >
    > > Export 'pcibios_enabled' so that when uvesafb is built as a
    > > loadable module (on X86_32), the build will succeed.
    > >
    > > ERROR: "pcibios_enabled" [drivers/video/uvesafb.ko] undefined!
    > >
    > > Patch v2 uses EXPORT_SYMBOL_GPL() as requested.
    > >
    > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
    > > Cc: Michal Januszewski <spock@gentoo.org>
    > > Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
    > > Cc: linux-fbdev@vger.kernel.org
    > > Cc: x86@kernel.org
    > > ---
    > > arch/x86/pci/pcbios.c | 1 +
    > > 1 file changed, 1 insertion(+)
    > >
    > > --- linux-next-20120313.orig/arch/x86/pci/pcbios.c
    > > +++ linux-next-20120313/arch/x86/pci/pcbios.c
    > > @@ -27,6 +27,7 @@
    > > #define PCIBIOS_HW_TYPE2_SPEC 0x20
    > >
    > > int pcibios_enabled;
    > > +EXPORT_SYMBOL_GPL(pcibios_enabled);
    > >
    > > /* According to the BIOS specification at:
    > > * http://members.datafast.net.au/dft0802/specs/bios21.pdf, we could
    > Acked-by: Wang YanQing <udknight@gmail.com>

    NAKked again by Alan Cox <alan@linux.intel.com>

    The fb code shouldn't be playing guessing games with thsi variable.
    I've pointed out both how to check if NX is enabled and how to set pages
    NX/non-NX.

    Even if you wanted to check the pci bios state we should export a helper
    method.

    So NAK.

    Alan


    \
     
     \ /
      Last update: 2012-03-21 10:31    [W:0.023 / U:0.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site