lkml.org 
[lkml]   [2012]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Disintegrate asm/system.h for Unicore32 [based on ver #3, changed by gxt]
    On 03/20/2012 05:33 PM, David Howells wrote:
    > Guan Xuetao<gxt@mprc.pku.edu.cn> wrote:
    >
    >> Disintegrate asm/system.h for Unicore32. (Compilation successful)
    >> The implementation details are not changed, but only splitted.
    >> BTW, some codestyles are adjusted.
    >>
    >> Signed-off-by: David Howells<dhowells@redhat.com>
    >> Signed-off-by: Guan Xuetao<gxt@mprc.pku.edu.cn>
    > Aha! Much better. It mostly looks reasonable, apart from one thing. See the
    > attached patch, which I'll roll in if you're happy with it.
    That's great. It's just what I want to do.
    > -extern void panic(const char *fmt, ...);
    > +/*
    > + * Generate a link failure on undefined symbol if the pointer points to a value
    > + * of unsupported size.
    > + */
    > +extern void __xchg_bad_pointer(void)
    A semicolon should be added at the end.
    > static inline unsigned long __xchg(unsigned long x, volatile void *ptr,
    > int size)
    > @@ -31,8 +35,8 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr,
    > : "memory", "cc");
    > break;
    > default:
    > - panic("xchg: bad data size: ptr 0x%p, size %d\n",
    > - ptr, size);
    > + __xchg_bad_pointer();
    > + break;
    I think the 'break' sentence is redundant.

    Thanks and Regards,
    Guan Xuetao


    \
     
     \ /
      Last update: 2012-03-21 02:35    [W:0.031 / U:59.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site