lkml.org 
[lkml]   [2012]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/10] cgroup: remove cgroup_add_file[s]()
On Tue, Mar 20, 2012 at 02:17:51PM +0530, Aneesh Kumar K.V wrote:
> Tejun Heo <tj@kernel.org> writes:
>
> > No controller is using cgroup_add_files[s](). Unexport them, and
> > convert cgroup_add_files() to handle NULL entry terminated array
> > instead of taking count explicitly and continue creation on failure
> > for internal use.
> >
>
> I am planning to use that in the HugeTLB extension of memcg.
>
> http://article.gmane.org/gmane.linux.kernel.mm/75470
>
> We need to have different limit and usage file for different HugeTLB
> page size supported.

Unless you have to alter available files cgroup-by-cgroup, you should
be fine. If you're trying to create different set of files depending
on cgroup, it's confusing - change your interface.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-03-20 17:03    [from the cache]
©2003-2011 Jasper Spaans