lkml.org 
[lkml]   [2012]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] ext4: Use pr_fmt and pr_<level>
On Tue, Mar 20, 2012 at 03:10:01AM -0400, David Miller wrote:
> > OK. Say I'm a scraper. How do I distinguish between:
> >
> > pr_info("foo");
> > printk(KERN_INFO "foo");
> >
> > Oh my. seems that both result in exactly the same thing ending up in the
> > dmesg buffer
>
> No it doesn't result in the same output, read the definitions again.
>
> pr_info can be influenced by pr_fmt, plain printk cannot

But if you don't use pr_fmt, it's the same. And even if you do, then
pr_info() is the same as printk(KERN_INFO pr_fmt ...). For a device
driver where cut and paste reuse happens, sure, it's handy. But for
the rest of the kernel, it doesn't really buy you anything.

And as I've said, something like ext4_msg(sb, ...) is **far** more
useful. I don't need a 1200-line patch that messes with debug
printk's that are #ifdef'ed out.

- Ted


\
 
 \ /
  Last update: 2012-03-20 14:05    [W:0.213 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site