Messages in this thread | | | Date | Tue, 20 Mar 2012 06:46:50 -0500 | From | Jason Wessel <> | Subject | Re: [Kgdb-bugreport] [PATCH 4/4] kgdb: x86: Detach gdb if machine shuts down or reboots |
| |
On 03/20/2012 06:18 AM, Sergei Shtylyov wrote: > Hello. > > On 20-03-2012 5:00, Jason Wessel wrote: > >>> An arch-independent hook has its advantages, no question. Maybe we >>> should just start this way and then evolved on top as needed. >> Sounds good to me. I added the reboot notifier patch into the merge queue for kgdb/kdb. >>> I was wondering why those other archs do not use the notifier. Maybe one >>> motivation is to avoid that too much code is excluded from the debugger >>> by detaching too early. Could possibly be addressed by making >>> detach-on-reboot runtime configurable. >> There really isn't a whole lot of code between reboot hook invoked from kernel_restart_prepare(), >> and the place where the reset is invoked. Specifically it looked like: >> usermodehelper_disable(); >> device_shutdown(); >> syscore_shutdown(); >> machine_restart(cmd); >> Attached is the patch you asked for the conditional behavior with respect to the reboot hook. > You forgot to attach it?
Source Forge [kgdb mailling list] is eating attachments. I had definitely attached it. See:
https://lkml.org/lkml/2012/3/19/735
I also included this patch in the potential merge queue as patch 5 of 5, sent to the kgdb mailing list.
http://sourceforge.net/mailarchive/message.php?msg_id=29008292
Jason.
Jason.
| |