lkml.org 
[lkml]   [2012]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator
Acked-by: Jin Park <jinyoungp@nvidia.com>

On 2012-03-02 오전 10:28, Axel Lin wrote:
> The reason we add *pdev in struct aat2870_regulator is to use it
> to get a pointer to struct aat2870_data.
> Save a pointer to struct aat2870_data instead of pdev in struct
> aat2870_regulator, this change makes the intention more clear.
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
> drivers/regulator/aat2870-regulator.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
> index 685ad43..9ed5c5d 100644
> --- a/drivers/regulator/aat2870-regulator.c
> +++ b/drivers/regulator/aat2870-regulator.c
> @@ -31,7 +31,7 @@
> #include<linux/mfd/aat2870.h>
>
> struct aat2870_regulator {
> - struct platform_device *pdev;
> + struct aat2870_data *aat2870;
> struct regulator_desc desc;
>
> const int *voltages; /* uV */
> @@ -60,7 +60,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev,
> unsigned selector)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->voltage_addr, ri->voltage_mask,
> selector<< ri->voltage_shift);
> @@ -69,7 +69,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev,
> static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
> u8 val;
> int ret;
>
> @@ -83,7 +83,7 @@ static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev)
> static int aat2870_ldo_enable(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->enable_addr, ri->enable_mask,
> ri->enable_mask);
> @@ -92,7 +92,7 @@ static int aat2870_ldo_enable(struct regulator_dev *rdev)
> static int aat2870_ldo_disable(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->enable_addr, ri->enable_mask, 0);
> }
> @@ -100,7 +100,7 @@ static int aat2870_ldo_disable(struct regulator_dev *rdev)
> static int aat2870_ldo_is_enabled(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
> u8 val;
> int ret;
>
> @@ -185,7 +185,7 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "Invalid device ID, %d\n", pdev->id);
> return -EINVAL;
> }
> - ri->pdev = pdev;
> + ri->aat2870 = dev_get_drvdata(pdev->dev.parent);
>
> rdev = regulator_register(&ri->desc,&pdev->dev,
> pdev->dev.platform_data, ri, NULL);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-03-02 06:17    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site