Messages in this thread |  | | | From | "Luck, Tony" <> | | Subject | RE: [PATCH 1/4] mce: Slim up struct mce | | Date | Fri, 2 Mar 2012 17:47:09 +0000 |
| |
> Drop unused ->apicid, make ->socketid __u16 since it is copied from > struct cpuinfo_86.phys_proc_id, reorder members and adjust padding so > that it remains packed and on a 64-byte boundary.
This structure is user visible via /dev/mcelog. The mcelog(8) daemon has been coded to cope with extra fields being added to the end of the structure (an old daemon that doesn't know what they are will just skip over them). But things will break if you change the offsets of any fields that it does know about.
Linus says - no breaking user space - so "NACK" for this patch.
-Tony
|  |