lkml.org 
[lkml]   [2012]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/3] netxen: qlogic ethernet : Fix Endian Bug.
    Date
    From: Santosh Nayak <santoshprasadnayak@gmail.com>

    Fix endian bug.
    Add a default case in 'netxen_list_config_vlan_ip'

    Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
    ---
    .../net/ethernet/qlogic/netxen/netxen_nic_main.c | 20 ++++++++++++--------
    1 files changed, 12 insertions(+), 8 deletions(-)

    diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
    index 8dc4a134..971b286 100644
    --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
    +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
    @@ -818,7 +818,7 @@ netxen_check_options(struct netxen_adapter *adapter)
    adapter->driver_mismatch = 1;
    return;
    }
    - ptr32[i] = cpu_to_le32(val);
    + ptr32[i] = val;
    offset += sizeof(u32);
    }

    @@ -3028,7 +3028,7 @@ netxen_list_config_vlan_ip(struct netxen_adapter *adapter,
    list_for_each(head, &adapter->vlan_ip_list) {
    cur = list_entry(head, struct nx_vlan_ip_list, list);

    - if (cur->ip_addr == ifa->ifa_address)
    + if (cur->ip_addr == be32_to_cpu(ifa->ifa_address))
    return;
    }

    @@ -3039,18 +3039,22 @@ netxen_list_config_vlan_ip(struct netxen_adapter *adapter,
    return;
    }

    - cur->ip_addr = ifa->ifa_address;
    + cur->ip_addr = be32_to_cpu(ifa->ifa_address);
    list_add_tail(&cur->list, &adapter->vlan_ip_list);
    break;
    case NX_IP_DOWN:
    list_for_each_entry_safe(cur, tmp_cur,
    &adapter->vlan_ip_list, list) {
    - if (cur->ip_addr == ifa->ifa_address) {
    + if (cur->ip_addr == be32_to_cpu(ifa->ifa_address)) {
    list_del(&cur->list);
    kfree(cur);
    break;
    }
    }
    + break;
    + default:
    + printk(KERN_ERR "%ld: Wrong event id \n", event);
    + break;
    }
    }
    static void
    @@ -3070,12 +3074,12 @@ netxen_config_indev_addr(struct netxen_adapter *adapter,
    switch (event) {
    case NETDEV_UP:
    netxen_config_ipaddr(adapter,
    - ifa->ifa_address, NX_IP_UP);
    + be32_to_cpu(ifa->ifa_address), NX_IP_UP);
    netxen_list_config_vlan_ip(adapter, ifa, NX_IP_UP);
    break;
    case NETDEV_DOWN:
    netxen_config_ipaddr(adapter,
    - ifa->ifa_address, NX_IP_DOWN);
    + be32_to_cpu(ifa->ifa_address), NX_IP_DOWN);
    netxen_list_config_vlan_ip(adapter, ifa, NX_IP_DOWN);
    break;
    default:
    @@ -3167,11 +3171,11 @@ recheck:

    switch (event) {
    case NETDEV_UP:
    - netxen_config_ipaddr(adapter, ifa->ifa_address, NX_IP_UP);
    + netxen_config_ipaddr(adapter, be32_to_cpu(ifa->ifa_address), NX_IP_UP);
    netxen_list_config_vlan_ip(adapter, ifa, NX_IP_UP);
    break;
    case NETDEV_DOWN:
    - netxen_config_ipaddr(adapter, ifa->ifa_address, NX_IP_DOWN);
    + netxen_config_ipaddr(adapter, be32_to_cpu(ifa->ifa_address), NX_IP_DOWN);
    netxen_list_config_vlan_ip(adapter, ifa, NX_IP_DOWN);
    break;
    default:
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2012-03-02 16:15    [W:0.025 / U:148.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site