[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 05/11] XFS: Fix lock ASSERT on UP
    > So this means we only ever check that the spinlock is held when
    > lockdep is turned on instead of whenever CONFIG_XFS_DEBUG is set?

    You should regularly test with lockdep anyways. If you don't you clearly
    have a testing gap. lockdep is likely to find many more locking bugs
    than any of your very sparse manual annotations.

    > That means it will rarely get checked during development instead of
    > all the time. That's not an improvement IMO....

    It's an improvement that an !CONFIG_SMP && CONFIG_XFS_DEBUG kernel
    will not blow up anymore.


     \ /
      Last update: 2012-03-20 03:31    [W:0.022 / U:5.764 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site