[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/9] ext4: Use pr_fmt and pr_<level>
On Mon, 19 Mar 2012, Ted Ts'o wrote:

> On Mon, Mar 19, 2012 at 10:44:10AM -0700, Joe Perches wrote:
>> This stuff ain't whitespace.
> I'll have to respectfully disagree with you. For ext4, as far as I am
> concerned, changing printk(KERN_INFO, ...) to pr_info(...) is *purely*
> a whitespace-level change.

Joe, if everything did change, what difference would it make?

just being a consistant style doesn't matter much, but if there is some
functionality that would be possible with pr_info(...) that would not be
possible with printk(KERN_INFO, ...), there may be more reason to change.

David Lang

 \ /
  Last update: 2012-03-20 02:31    [W:0.121 / U:0.920 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site