Messages in this thread |  | | | Date | Mon, 19 Mar 2012 18:28:17 -0700 (PDT) | | From | david@lang ... | | Subject | Re: [PATCH 2/9] ext4: Use pr_fmt and pr_<level> |
| |
On Mon, 19 Mar 2012, Ted Ts'o wrote:
> On Mon, Mar 19, 2012 at 10:44:10AM -0700, Joe Perches wrote: >> >> This stuff ain't whitespace. >> > > I'll have to respectfully disagree with you. For ext4, as far as I am > concerned, changing printk(KERN_INFO, ...) to pr_info(...) is *purely* > a whitespace-level change.
Joe, if everything did change, what difference would it make?
just being a consistant style doesn't matter much, but if there is some functionality that would be possible with pr_info(...) that would not be possible with printk(KERN_INFO, ...), there may be more reason to change.
David Lang
|  |