[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] gpio: add support for ITE IT87xx Super I/O GPIO, replacing gpio-it8761e.
Il giorno lun, 19/03/2012 alle 21.53 +0000, Grant Likely ha scritto:
> When you move and modify a driver all in one patch, then I don't have
> any way to review what has changed and therefore I cannot apply the
> patch. At the very least the -M flag must be used with git diff so
> that it can detect the rename, but even better is to also split the
> move and the modification into separate patches.

The problem is that it's not a move-and-modification: the new driver I
wrote from scratch, basing myself only on the code-flow from the it8761e
previously available (for the one I sent last week), then I re-added the
it8761e-specific features to that one when you asked me to see if I
could merge them back.

So for what it's worth, `git diff -M` won't show you any difference for
this as it won't recognize the new driver as a move-and-modification at
all... the only thing they have in common is the headers' inclusion..

Diego Elio Pettenò — Flameeyes

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2012-03-19 23:01    [W:0.033 / U:31.444 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site