lkml.org 
[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf report: Treat an argument as a symbol filter
    Commit-ID:  6db6127c4dad634ab98709b81e2f2770890b0d53
    Gitweb: http://git.kernel.org/tip/6db6127c4dad634ab98709b81e2f2770890b0d53
    Author: Namhyung Kim <namhyung.kim@lge.com>
    AuthorDate: Fri, 16 Mar 2012 17:50:55 +0900
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Fri, 16 Mar 2012 16:44:36 -0300

    perf report: Treat an argument as a symbol filter

    As Ingo requested, it'd be better off treating first (and the only)
    argument as a symbol filter, so that user doesn't need to input the
    symbol on the dialog window on TUI.

    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1331887855-874-5-git-send-email-namhyung.kim@lge.com
    Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-report.c | 15 ++++++++++-----
    1 files changed, 10 insertions(+), 5 deletions(-)

    diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
    index 80fb907..c005458 100644
    --- a/tools/perf/builtin-report.c
    +++ b/tools/perf/builtin-report.c
    @@ -715,11 +715,16 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)
    } else
    symbol_conf.exclude_other = false;

    - /*
    - * Any (unrecognized) arguments left?
    - */
    - if (argc)
    - usage_with_options(report_usage, options);
    + if (argc) {
    + /*
    + * Special case: if there's an argument left then assume that
    + * it's a symbol filter:
    + */
    + if (argc > 1)
    + usage_with_options(report_usage, options);
    +
    + report.symbol_filter_str = argv[0];
    + }

    sort_entry__setup_elide(&sort_comm, symbol_conf.comm_list, "comm", stdout);


    \
     
     \ /
      Last update: 2012-03-19 21:09    [W:0.025 / U:1.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site