Messages in this thread | | | Date | Mon, 19 Mar 2012 13:54:56 -0500 | From | Seth Jennings <> | Subject | Re: [PATCH] staging: zsmalloc: add user-definable alloc/free funcs |
| |
On 03/16/2012 04:32 PM, Greg Kroah-Hartman wrote: > On Fri, Mar 16, 2012 at 04:04:48PM -0500, Seth Jennings wrote: >> This patch allows a zsmalloc user to define the page >> allocation and free functions to be used when growing >> or releasing parts of the memory pool. >> >> The functions are passed in the struct zs_pool_ops parameter >> of zs_create_pool() at pool creation time. If this parameter >> is NULL, zsmalloc uses alloc_page and __free_page() by default. >> >> While there is no current user of this functionality, zcache >> development plans to make use of it in the near future. > > I'm starting to get tired of seeing new features be added to this chunk > of code, and the other related bits, without any noticable movement > toward getting it merged into the mainline tree.
Fair enough
> > So, I'm going to take a stance here and say, no more new features until > it gets merged into the "real" part of the kernel tree, as you all > should not be spinning your wheels on new stuff, when there's no > guarantee that the whole thing could just be rejected outright tomorrow. > > I'm sorry, I know this isn't fair for your specific patch, but we have > to stop this sometime, and as this patch adds code isn't even used by > anyone, its a good of a time as any.
So, this the my first "promotion from staging" rodeo. I would love to see this code mainlined ASAP. How would I/we go about doing that?
I guess another way to ask is, what needs to be done in the way of code quality and acks in the community to promote zcache to /drivers/misc for example?
Also, the tmem part of zcache will (probably, Dan?) be broken out an placed in /lib.
-- Seth
| |