[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/9] ext4: Use pr_fmt and pr_<level>
From: "Ted Ts'o" <>
Date: Mon, 19 Mar 2012 00:34:20 -0400

> Things like printk(KERN_INFO, ...) are quite well established, and
> changing really doesn't add any value.

It also allows you to modify pr_fmt at the top of the file or
elsewhere and have it influence the output, as just one example
of how it's better.

As a maintainer you can only take one of two positions:

1) Accept all properly written patches that convert code over to use
the new and recommended way of doing things, such as pr_info() et

2) Advocate on linux-kernel to remove these new interfaces or improve
them if you don't find them suitable, and then once suitable go
back to #1.

Just keeping things the way they are because you simply feel like it
is really not acceptable Ted.

 \ /
  Last update: 2012-03-19 06:15    [W:0.146 / U:2.180 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site