lkml.org 
[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -V4 07/10] hugetlbfs: Add memcg control files for hugetlbfs
    (2012/03/19 16:14), Aneesh Kumar K.V wrote:

    > On Mon, 19 Mar 2012 11:56:25 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
    >> (2012/03/17 2:39), Aneesh Kumar K.V wrote:
    >>
    >>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
    >>>
    >>> This add control files for hugetlbfs in memcg
    >>>
    >>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
    >>
    >>
    >> I have a question. When a user does
    >>
    >> 1. create memory cgroup as
    >> /cgroup/A
    >> 2. insmod hugetlb.ko
    >> 3. ls /cgroup/A
    >>
    >> and then, files can be shown ? Don't we have any problem at rmdir A ?
    >>
    >> I'm sorry if hugetlb never be used as module.
    >
    > HUGETLBFS cannot be build as kernel module
    >
    >
    >>
    >> a comment below.
    >>
    >>> ---
    >>> include/linux/hugetlb.h | 17 +++++++++++++++
    >>> include/linux/memcontrol.h | 7 ++++++
    >>> mm/hugetlb.c | 25 ++++++++++++++++++++++-
    >>> mm/memcontrol.c | 48 ++++++++++++++++++++++++++++++++++++++++++++
    >>> 4 files changed, 96 insertions(+), 1 deletions(-)
    >
    >
    > ......
    >
    >>>
    >>> +#ifdef CONFIG_MEM_RES_CTLR_HUGETLB
    >>> +static char *mem_fmt(char *buf, unsigned long n)
    >>> +{
    >>> + if (n >= (1UL << 30))
    >>> + sprintf(buf, "%luGB", n >> 30);
    >>> + else if (n >= (1UL << 20))
    >>> + sprintf(buf, "%luMB", n >> 20);
    >>> + else
    >>> + sprintf(buf, "%luKB", n >> 10);
    >>> + return buf;
    >>> +}
    >>> +
    >>> +int mem_cgroup_hugetlb_file_init(int idx)
    >>> +{
    >>
    >>
    >> __init ?
    >
    > Added .
    >
    >> And... do we have guarantee that this function is called before
    >> creating root mem cgroup even if CONFIG_HUGETLBFS=y ?
    >>
    >
    > Yes. This should be called before creating root mem cgroup.
    >


    O.K. BTW, please read Tejun's recent post..

    https://lkml.org/lkml/2012/3/16/522

    Can you use his methods ?

    I guess you can write...

    CGROUP_SUBSYS_CFTYLES_COND(mem_cgroup_subsys,
    hugetlb_cgroup_files,
    if XXXXMB hugetlb is allowed);

    Hmm.

    Thanks,
    -Kame




    \
     
     \ /
      Last update: 2012-03-19 08:39    [W:0.027 / U:0.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site